]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: Fix libvirtd free() segfault if virDomainChrSourceDefNew(...) fails
authorMarc Hartmayer <mhartmay@linux.vnet.ibm.com>
Thu, 9 Feb 2017 14:13:36 +0000 (15:13 +0100)
committerLaine Stump <laine@laine.org>
Thu, 9 Feb 2017 19:18:51 +0000 (14:18 -0500)
If virDomainChrSourceDefNew(xmlopt) fails, it will lead to free()ing
the uninitialized pointer bus. The fix for this is to initialize bus
with NULL.

Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>
src/conf/domain_conf.c

index ba55791a0454731bab4d9b4d45a38df61096f77e..1bc72a4e90214f6aa10aa98e8deebc8235b3d85f 100644 (file)
@@ -13317,7 +13317,7 @@ virDomainRedirdevDefParseXML(virDomainXMLOptionPtr xmlopt,
 {
     xmlNodePtr cur;
     virDomainRedirdevDefPtr def;
-    char *bus, *type = NULL;
+    char *bus = NULL, *type = NULL;
     int remaining;
 
     if (VIR_ALLOC(def) < 0)