]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
btrfs: add unlikely to unexpected error case in extent_writepages()
authorFilipe Manana <fdmanana@suse.com>
Sun, 12 Oct 2025 09:43:02 +0000 (10:43 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 24 Nov 2025 20:59:08 +0000 (21:59 +0100)
We don't expect to hit errors and log the error message, so add the
unlikely annotation to make it clear and to hint the compiler that it may
reorganize code to be more efficient.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Anand Jain <asj@kernel.org>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent_io.c

index c741de16453563544ede0befcb3d94bd4d161d31..cb680cdeb77d200f246dd1632fc75bcba9e3c813 100644 (file)
@@ -1874,7 +1874,7 @@ static int extent_writepage(struct folio *folio, struct btrfs_bio_ctrl *bio_ctrl
                                  folio_size(folio), bio_ctrl, i_size);
        if (ret == 1)
                return 0;
-       if (ret < 0)
+       if (unlikely(ret < 0))
                btrfs_err_rl(fs_info,
 "failed to submit blocks, root=%lld inode=%llu folio=%llu submit_bitmap=%*pbl: %d",
                             btrfs_root_id(inode->root), btrfs_ino(inode),