]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
refactor: reformat code and mark unused parameters 11829/head
authorDaniel Ruf <mac1@daniel-ruf.de>
Sat, 5 Oct 2019 15:48:22 +0000 (17:48 +0200)
committerDaniel Ruf <mac1@daniel-ruf.de>
Sat, 5 Oct 2019 15:48:22 +0000 (17:48 +0200)
docs/assets/img/gulpfile.js
js/foundation.core.js
js/foundation.core.utils.js
js/foundation.responsiveAccordionTabs.js

index d901908568166d662741e99fa13d6ca406bad782..79c7d71761291e67a01dac7fd243d708d07bfb6d 100755 (executable)
@@ -37,7 +37,7 @@ gulp.task('clean', function(done) {
 
 // Copy files out of the assets folder
 // This task skips over the "img", "js", and "scss" folders, which are parsed separately
-gulp.task('copy', function(done) {
+gulp.task('copy', function(_done) {
   gulp.src(paths.assets)
     .pipe(gulp.dest('./dist/assets'));
 });
index 8b7b88abe4aefe678ead3d307c9da8c02416ec0d..3308529508cfa22c464abf12512862841f3a7b04 100644 (file)
@@ -159,8 +159,8 @@ var Foundation = {
             opts = {};
             
         if($el.attr('data-options')){
-          var thing = $el.attr('data-options').split(';').forEach(function(e, i){
-            var opt = e.split(':').map(function(el){ return el.trim(); });
+          $el.attr('data-options').split(';').forEach(function(option, _index){
+            var opt = option.split(':').map(function(el){ return el.trim(); });
             if(opt[0]) opts[opt[0]] = parseValue(opt[1]);
           });
         }
index b6778b72b3c4123e479e610f925a1d9692dd5f0b..2a10f5675e42c39b155d1ff2a7418a8696648c77 100644 (file)
@@ -51,7 +51,7 @@ function transitionend($elem){
       end = transitions[t];
     }
   }
-  if(end){
+  if (end) {
     return end;
   }else{
     end = setTimeout(function(){
index 8d73237b6fe727de11811a386a4dd0b962dd0655..5a0fa0841ebe265fe355d65f46c698c839e66ae4 100644 (file)
@@ -190,7 +190,7 @@ class ResponsiveAccordionTabs extends Plugin{
     if (fromString === 'tabs') {
       $panels = $panels.children('.'+tabsPanel).removeClass(tabsPanel).removeAttr('role').removeAttr('aria-hidden').removeAttr('aria-labelledby');
       $panels.children('a').removeAttr('role').removeAttr('aria-controls').removeAttr('aria-selected');
-    }else{
+    } else {
       $panels = $liHeads.children('[data-tab-content]').removeClass('accordion-content');
     };
 
@@ -203,13 +203,13 @@ class ResponsiveAccordionTabs extends Plugin{
         $liHeads.addClass('accordion-item').attr('data-accordion-item','');
         $liHeadsA.addClass('accordion-title');
       });
-    }else if (toSet === 'tabs'){
+    } else if (toSet === 'tabs') {
       var $tabsContent = $('[data-tabs-content='+_this.$element.attr('id')+']');
       var $placeholder = $('#tabs-placeholder-'+_this.$element.attr('id'));
       if ($placeholder.length) {
         $tabsContent = $('<div class="tabs-content"></div>').insertAfter($placeholder).attr('data-tabs-content',_this.$element.attr('id'));
         $placeholder.remove();
-      }else{
+      } else {
         $tabsContent = $('<div class="tabs-content"></div>').insertAfter(_this.$element).attr('data-tabs-content',_this.$element.attr('id'));
       };
       $panels.each(function(key,value){
@@ -219,7 +219,7 @@ class ResponsiveAccordionTabs extends Plugin{
         if (hash !== id) {
           if (hash !== '') {
             $(value).attr('id',hash);
-          }else{
+          } else {
             hash = id;
             $(value).attr('id',hash);
             $($liHeadsA.get(key)).attr('href',$($liHeadsA.get(key)).attr('href').replace('#','')+'#'+hash);
@@ -241,7 +241,7 @@ class ResponsiveAccordionTabs extends Plugin{
    * @see Tabs.selectTab
    * @function
    */
-  open(target) {
+  open(_target) {
     if (this.currentRule && typeof this.currentRule.open === 'function') {
       return this.currentRule.open(this.currentPlugin, ...arguments);
     }
@@ -253,7 +253,7 @@ class ResponsiveAccordionTabs extends Plugin{
    * @see Accordion.up
    * @function
    */
-  close(target) {
+  close(_target) {
     if (this.currentRule && typeof this.currentRule.close === 'function') {
       return this.currentRule.close(this.currentPlugin, ...arguments);
     }
@@ -265,7 +265,7 @@ class ResponsiveAccordionTabs extends Plugin{
    * @see Accordion.toggle
    * @function
    */
-  toggle(target) {
+  toggle(_target) {
     if (this.currentRule && typeof this.currentRule.toggle === 'function') {
       return this.currentRule.toggle(this.currentPlugin, ...arguments);
     }