]> git.ipfire.org Git - thirdparty/open-vm-tools.git/commitdiff
Remove the X{Grab,Ungrab}Server calls in resolutionSet
authorVMware, Inc <>
Tue, 28 Jun 2011 19:51:56 +0000 (12:51 -0700)
committerMarcelo Vanzin <mvanzin@vmware.com>
Tue, 28 Jun 2011 19:51:56 +0000 (12:51 -0700)
When using vesa X was getting into a sort of race condition because we were
not calling XSync after the X{Grab,Ungrab}Server calls.  This was causing X
to appear to hang.  Really since we aren't setting anything (only reading values)
I don't see a reason to keep these calls.  Hence remove them and fix the bug.

Signed-off-by: Marcelo Vanzin <mvanzin@vmware.com>
open-vm-tools/services/plugins/resolutionSet/resolutionX11.c

index 50a1a27634e5b9936b7c3da500bdf3ca523f40ec..d4687111a4c8df02eccfa1b07d42cfd1b788ffeb 100644 (file)
@@ -315,8 +315,6 @@ ResolutionCanSet(void)
       unsigned int num;
       int i;
 
-      XGrabServer(resInfoX->display);
-
       xrrRes = XRRGetScreenResources(resInfoX->display, resInfoX->rootWindow);
 
       if (xrrRes) {
@@ -345,8 +343,6 @@ ResolutionCanSet(void)
          XRRFreeScreenResources(xrrRes);
       }
 
-      XUngrabServer(resInfoX->display);
-
       if (resInfoX->canUseRandR12) {
          return TRUE;
       }