]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: i2c: imx290: Remove unneeded assignment of subdev device pointer
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Thu, 3 Jul 2025 21:42:06 +0000 (23:42 +0200)
committerHans Verkuil <hverkuil@xs4all.nl>
Thu, 10 Jul 2025 09:32:26 +0000 (11:32 +0200)
The core helper v4l2_i2c_subdev_init() already assignees the subdevices
dev pointer to the device associated with the i2c client passed to it.
And 'imx290->dev' is assigned to '&client->dev' already in probe before
calling imx290_subdev_init().

Remove the duplicated open-coded assignment in the driver, there is no
reason to do it twice.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/imx290.c

index fbf7eba3d71d8ac72a2f42ca374f9387943666d2..4f3f386c53534adc7cd0f4242143bc8142da11d4 100644 (file)
@@ -1294,7 +1294,6 @@ static int imx290_subdev_init(struct imx290 *imx290)
         * will already be prevented even before the delay.
         */
        v4l2_i2c_subdev_init(&imx290->sd, client, &imx290_subdev_ops);
-       imx290->sd.dev = imx290->dev;
        pm_runtime_mark_last_busy(imx290->dev);
        pm_runtime_put_autosuspend(imx290->dev);