]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
powerpc/83xx: Add missing of_node_put() after of_device_is_available()
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 23 Feb 2019 13:20:34 +0000 (14:20 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 23 Sep 2019 20:11:45 +0000 (21:11 +0100)
commit 4df2cb633b5b22ba152511f1a55e718efca6c0d9 upstream.

Add an of_node_put() when a tested device node is not available.

Fixes: c026c98739c7e ("powerpc/83xx: Do not configure or probe disabled FSL DR USB controllers")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/powerpc/platforms/83xx/usb.c

index 1ad748bb39b4b506c8596d658d612048946ea46d..7eb4e4c3b980e6e47590745f8cc04a0c594919bc 100644 (file)
@@ -222,8 +222,10 @@ int mpc837x_usb_cfg(void)
        int ret = 0;
 
        np = of_find_compatible_node(NULL, NULL, "fsl-usb2-dr");
-       if (!np || !of_device_is_available(np))
+       if (!np || !of_device_is_available(np)) {
+               of_node_put(np);
                return -ENODEV;
+       }
        prop = of_get_property(np, "phy_type", NULL);
 
        if (!prop || (strcmp(prop, "ulpi") && strcmp(prop, "serial"))) {