]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
eth: fbnic: Fix tx_dropped reporting
authorMohsin Bashir <mohsin.bashr@gmail.com>
Sat, 2 Aug 2025 02:46:35 +0000 (19:46 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 5 Aug 2025 23:01:45 +0000 (16:01 -0700)
Correctly copy the tx_dropped stats from the fbd->hw_stats to the
rtnl_link_stats64 struct.

Fixes: 5f8bd2ce8269 ("eth: fbnic: add support for TMI stats")
Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250802024636.679317-2-mohsin.bashr@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/meta/fbnic/fbnic_netdev.c

index 04bb6e7147a201938dcd0c40cd689aa85be369cc..c0c9808afdd0af61bd5b8d888791916ecc99258a 100644 (file)
@@ -422,16 +422,16 @@ static void fbnic_get_stats64(struct net_device *dev,
        tx_packets = stats->packets;
        tx_dropped = stats->dropped;
 
-       stats64->tx_bytes = tx_bytes;
-       stats64->tx_packets = tx_packets;
-       stats64->tx_dropped = tx_dropped;
-
        /* Record drops from Tx HW Datapath */
        tx_dropped += fbd->hw_stats.tmi.drop.frames.value +
                      fbd->hw_stats.tti.cm_drop.frames.value +
                      fbd->hw_stats.tti.frame_drop.frames.value +
                      fbd->hw_stats.tti.tbi_drop.frames.value;
 
+       stats64->tx_bytes = tx_bytes;
+       stats64->tx_packets = tx_packets;
+       stats64->tx_dropped = tx_dropped;
+
        for (i = 0; i < fbn->num_tx_queues; i++) {
                struct fbnic_ring *txr = fbn->tx[i];