No need to call fr_network_listen_delete here

It only looks up the socket and calls fr_network_socket_dead, but the
socket likely has already been removed from the tree of sockets by the
socket talloc destructor - which is what is calling mod_close

diff --git a/src/lib/io/master.c b/src/lib/io/master.c
index 509aadb801fba0e09361b5e76850775eeb461ce4..3c371937c8882838aaac26cd76292eedb9088657 100644 (file)
--- a/src/lib/io/master.c
+++ b/src/lib/io/master.c
@@ -2800,13 +2800,6 @@ static int mod_close(fr_listen_t *li)
        }
        pthread_mutex_unlock(&connection->parent->mutex);
 
-       /*
-        *      Clean up listener
-        */
-       if (unlikely(fr_network_listen_delete(connection->nr, child) < 0)) {
-               PERROR("Failed to delete connection %s", connection->name);
-       }
-
        talloc_free(connection->mi);
 
        return 0;