]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
AArch64: Add gdbserver MTE support
authorLuis Machado <luis.machado@linaro.org>
Mon, 15 Jun 2020 18:38:43 +0000 (15:38 -0300)
committerLuis Machado <luis.machado@linaro.org>
Thu, 16 Jul 2020 16:09:27 +0000 (13:09 -0300)
Adds the AArch64-specific memory tagging support (MTE) by implementing the
required hooks and checks for GDBserver.

gdbserver/ChangeLog:

YYYY-MM-DD  Luis Machado  <luis.machado@linaro.org>

* Makefile.in (SFILES): Add /../gdb/nat/aarch64-mte-linux-ptrace.c.
* configure.srv (aarch64*-*-linux*): Add arch/aarch64-mte-linux.o and
nat/aarch64-mte-linux-ptrace.o.
* linux-aarch64-low.cc: Include nat/aarch64-mte-linux-ptrace.h.
(class aarch64_target) <supports_memory_tagging>
<fetch_memtags, store_memtags>: New method overrides.
(aarch64_target::supports_memory_tagging)
(aarch64_target::fetch_memtags)
(aarch64_target::store_memtags): New methods.

gdbserver/Makefile.in
gdbserver/configure.srv
gdbserver/linux-aarch64-low.cc

index 9d7687be534feb943209b86c3b31f018113cb1b1..8e54e1fd09f410c1a2d4e0c68d2aa34a82760beb 100644 (file)
@@ -212,6 +212,7 @@ SFILES = \
        $(srcdir)/../gdb/arch/ppc-linux-common.c \
        $(srcdir)/../gdb/arch/riscv.c \
        $(srcdir)/../gdb/nat/aarch64-sve-linux-ptrace.c \
+       $(srcdir)/../gdb/nat/aarch64-mte-linux-ptrace.c \
        $(srcdir)/../gdb/nat/linux-btrace.c \
        $(srcdir)/../gdb/nat/linux-namespaces.c \
        $(srcdir)/../gdb/nat/linux-osdata.c \
index 5e33bd9c54d6d37390ddc1c77c017588baf57494..e8d599e8663393d358254ca7db324c032c6ded52 100644 (file)
@@ -52,8 +52,10 @@ case "${gdbserver_host}" in
                        srv_tgtobj="$srv_tgtobj nat/aarch64-linux.o"
                        srv_tgtobj="$srv_tgtobj arch/aarch64-insn.o"
                        srv_tgtobj="$srv_tgtobj arch/aarch64.o"
+                       srv_tgtobj="$srv_tgtobj arch/aarch64-mte-linux.o"
                        srv_tgtobj="$srv_tgtobj linux-aarch64-tdesc.o"
                        srv_tgtobj="$srv_tgtobj nat/aarch64-sve-linux-ptrace.o"
+                       srv_tgtobj="$srv_tgtobj nat/aarch64-mte-linux-ptrace.o"
                        srv_tgtobj="${srv_tgtobj} $srv_linux_obj"
                        srv_linux_regsets=yes
                        srv_linux_thread_db=yes
index 22485d9466dfbeafa2d8b1d0b9b34b3fb958fecb..f8d2511fffe707997c04f8b58b676d811da6d6e7 100644 (file)
 #include "linux-aarch32-tdesc.h"
 #include "linux-aarch64-tdesc.h"
 #include "nat/aarch64-sve-linux-ptrace.h"
+#include "nat/aarch64-mte-linux-ptrace.h"
 #include "tdesc.h"
 
 #ifdef HAVE_SYS_REG_H
 #include <sys/reg.h>
 #endif
 
+#ifdef HAVE_GETAUXVAL
+#include <sys/auxv.h>
+#endif
+
 /* Linux target op definitions for the AArch64 architecture.  */
 
 class aarch64_target : public linux_process_target
@@ -82,6 +87,14 @@ public:
 
   struct emit_ops *emit_ops () override;
 
+  bool supports_memory_tagging () override;
+
+  int fetch_memtags (CORE_ADDR address, size_t len,
+                    gdb::byte_vector &tags) override;
+
+  int store_memtags (CORE_ADDR address, size_t len,
+                    const gdb::byte_vector &tags) override;
+
 protected:
 
   void low_arch_setup () override;
@@ -3201,6 +3214,46 @@ aarch64_target::breakpoint_kind_from_current_state (CORE_ADDR *pcptr)
     return arm_breakpoint_kind_from_current_state (pcptr);
 }
 
+/* Returns true if memory tagging is supported.  */
+bool
+aarch64_target::supports_memory_tagging ()
+{
+  if (current_thread == NULL)
+    {
+      /* We don't have any processes running, so don't attempt to
+        use linux_get_hwcap2 as it will try to fetch the current
+        thread id.  Instead, just fetch the auxv from the self
+        PID.  */
+#ifdef HAVE_GETAUXVAL
+      return (getauxval (AT_HWCAP2) & HWCAP2_MTE) != 0;
+#else
+      return true;
+#endif
+    }
+
+  return (linux_get_hwcap2 (8) & HWCAP2_MTE) != 0;
+}
+
+int
+aarch64_target::fetch_memtags (CORE_ADDR address, size_t len,
+                              gdb::byte_vector &tags)
+{
+  /* Allocation tags are per-process, so any tid is fine.  */
+  int tid = lwpid_of (current_thread);
+
+  return aarch64_mte_fetch_memtags (tid, address, len, tags);
+}
+
+int
+aarch64_target::store_memtags (CORE_ADDR address, size_t len,
+                              const gdb::byte_vector &tags)
+{
+  /* Allocation tags are per-process, so any tid is fine.  */
+  int tid = lwpid_of (current_thread);
+
+  return aarch64_mte_store_memtags (tid, address, len, tags);
+}
+
 /* The linux target ops object.  */
 
 linux_process_target *the_linux_target = &the_aarch64_target;