add User-Password warning to rlm_chap

diff --git a/src/modules/rlm_chap/rlm_chap.c b/src/modules/rlm_chap/rlm_chap.c
index 7ac0b020e494e97be7a0d66f7909fc9a5377f8a9..72c68b0b7dc20a7d7a1608f4d6a108b4df7956f1 100644 (file)
--- a/src/modules/rlm_chap/rlm_chap.c
+++ b/src/modules/rlm_chap/rlm_chap.c
@@ -99,7 +99,16 @@ static int chap_authenticate(void *instance, REQUEST *request)
                request->username->vp_strvalue);
 
        if ((passwd_item = pairfind(request->config_items, PW_CLEARTEXT_PASSWORD, 0)) == NULL){
-         RDEBUG("Cleartext-Password is required for authentication");
+               if ((passwd_item = pairfind(request->config_items, PW_USER_PASSWORD, 0)) != NULL){
+                       RDEBUG("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
+                       RDEBUG("!!! Please update your configuration so that the \"known !!!");
+                       RDEBUG("!!! good\" clear text password is in Cleartext-Password, !!!");
+                       RDEBUG("!!! and NOT in User-Password.                           !!!");
+                       RDEBUG("!!!                                                     !!!");
+                       RDEBUG("!!! Authentication will fail because of this.           !!!");
+                       RDEBUG("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
+               }
+               RDEBUG("Cleartext-Password is required for authentication");
                snprintf(module_fmsg, sizeof(module_fmsg),
                         "rlm_chap: Clear text password not available");
                module_fmsg_vp = pairmake("Module-Failure-Message",