]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
yaml: fix dead store
authorVictor Julien <vjulien@oisf.net>
Thu, 20 Apr 2023 17:40:38 +0000 (19:40 +0200)
committerVictor Julien <vjulien@oisf.net>
Mon, 24 Apr 2023 05:17:22 +0000 (07:17 +0200)
conf-yaml-loader.c:391:17: warning: Value stored to 'retval' is never read [deadcode.DeadStores]
                retval = -1;
                ^        ~~
1 warning generated.

src/conf-yaml-loader.c

index cef10ec88f07c178c1d9760ce6e5e7c0633fb31a..9312a189e8a4e7426d79609fa9e7af0d26f9b071 100644 (file)
@@ -388,7 +388,6 @@ static int ConfYamlParse(yaml_parser_t *parser, ConfNode *parent, int inseq, int
             SCLogDebug("event.type=YAML_MAPPING_START_EVENT; state=%d", state);
             if (state == CONF_INCLUDE) {
                 SCLogError("Include fields cannot be a mapping: line %zu", parser->mark.line);
-                retval = -1;
                 goto fail;
             }
             if (inseq) {