]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
platform/x86: barco-p50: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 8 Apr 2025 07:19:53 +0000 (09:19 +0200)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 11 Apr 2025 11:05:11 +0000 (14:05 +0300)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20250408-gpiochip-set-rv-platform-x86-v1-1-6f67e76a722c@linaro.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/barco-p50-gpio.c

index 143d14548565fc4b87ad467f86abefb505fa761f..bb3393bbfb89fd18203d0da9aaea2a73b1982c93 100644 (file)
@@ -268,15 +268,19 @@ static int p50_gpio_get(struct gpio_chip *gc, unsigned int offset)
        return ret;
 }
 
-static void p50_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)
+static int p50_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)
 {
        struct p50_gpio *p50 = gpiochip_get_data(gc);
+       int ret;
 
        mutex_lock(&p50->lock);
 
-       p50_send_mbox_cmd(p50, P50_MBOX_CMD_WRITE_GPIO, gpio_params[offset], value);
+       ret = p50_send_mbox_cmd(p50, P50_MBOX_CMD_WRITE_GPIO,
+                               gpio_params[offset], value);
 
        mutex_unlock(&p50->lock);
+
+       return ret;
 }
 
 static int p50_gpio_probe(struct platform_device *pdev)
@@ -312,7 +316,7 @@ static int p50_gpio_probe(struct platform_device *pdev)
        p50->gc.base = -1;
        p50->gc.get_direction = p50_gpio_get_direction;
        p50->gc.get = p50_gpio_get;
-       p50->gc.set = p50_gpio_set;
+       p50->gc.set_rv = p50_gpio_set;
 
 
        /* reset mbox */