]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rtc: tps6594: introduce private structure as drvdata
authorRichard Genoud <richard.genoud@bootlin.com>
Tue, 18 Jun 2024 14:18:50 +0000 (16:18 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 27 Jun 2024 22:18:55 +0000 (00:18 +0200)
This patch will prepare for the next one (power management support) by
introducing struct tps6594_rtc.

No functionnal change.

Signed-off-by: Richard Genoud <richard.genoud@bootlin.com>
Link: https://lore.kernel.org/r/20240618141851.1810000-3-richard.genoud@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-tps6594.c

index bc8dc735aa2384846496cfe220222f81a449da2b..06af177b2d782d3246c21376b3e989d88497238b 100644 (file)
 // Multiplier for ppb conversions
 #define PPB_MULT NANO
 
+struct tps6594_rtc {
+       struct rtc_device *rtc_dev;
+};
+
 static int tps6594_rtc_alarm_irq_enable(struct device *dev,
                                        unsigned int enabled)
 {
@@ -325,11 +329,11 @@ static int tps6594_rtc_set_offset(struct device *dev, long offset)
        return tps6594_rtc_set_calibration(dev, calibration);
 }
 
-static irqreturn_t tps6594_rtc_interrupt(int irq, void *rtc)
+static irqreturn_t tps6594_rtc_interrupt(int irq, void *data)
 {
-       struct device *dev = rtc;
+       struct device *dev = data;
        struct tps6594 *tps = dev_get_drvdata(dev->parent);
-       struct rtc_device *rtc_dev = dev_get_drvdata(dev);
+       struct tps6594_rtc *rtc = dev_get_drvdata(dev);
        int ret;
        u32 rtc_reg;
 
@@ -337,7 +341,7 @@ static irqreturn_t tps6594_rtc_interrupt(int irq, void *rtc)
        if (ret)
                return IRQ_NONE;
 
-       rtc_update_irq(rtc_dev, 1, RTC_IRQF | RTC_AF);
+       rtc_update_irq(rtc->rtc_dev, 1, RTC_IRQF | RTC_AF);
 
        return IRQ_HANDLED;
 }
@@ -356,13 +360,17 @@ static int tps6594_rtc_probe(struct platform_device *pdev)
 {
        struct tps6594 *tps = dev_get_drvdata(pdev->dev.parent);
        struct device *dev = &pdev->dev;
-       struct rtc_device *rtc;
+       struct tps6594_rtc *rtc;
        int irq;
        int ret;
 
-       rtc = devm_rtc_allocate_device(dev);
-       if (IS_ERR(rtc))
-               return PTR_ERR(rtc);
+       rtc = devm_kzalloc(dev, sizeof(*rtc), GFP_KERNEL);
+       if (!rtc)
+               return -ENOMEM;
+
+       rtc->rtc_dev = devm_rtc_allocate_device(dev);
+       if (IS_ERR(rtc->rtc_dev))
+               return PTR_ERR(rtc->rtc_dev);
 
        // Enable crystal oscillator.
        ret = regmap_set_bits(tps->regmap, TPS6594_REG_RTC_CTRL_2,
@@ -423,11 +431,11 @@ static int tps6594_rtc_probe(struct platform_device *pdev)
                return dev_err_probe(dev, ret,
                                     "Failed to init rtc as wakeup source\n");
 
-       rtc->ops = &tps6594_rtc_ops;
-       rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
-       rtc->range_max = RTC_TIMESTAMP_END_2099;
+       rtc->rtc_dev->ops = &tps6594_rtc_ops;
+       rtc->rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_2000;
+       rtc->rtc_dev->range_max = RTC_TIMESTAMP_END_2099;
 
-       return devm_rtc_register_device(rtc);
+       return devm_rtc_register_device(rtc->rtc_dev);
 }
 
 static const struct platform_device_id tps6594_rtc_id_table[] = {