]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
python/gpo.py: avoid SDDL conversion for dsacl2fsacl
authorRalph Boehme <slow@samba.org>
Mon, 31 Jul 2023 13:56:26 +0000 (15:56 +0200)
committerRalph Boehme <slow@samba.org>
Wed, 19 Mar 2025 14:58:32 +0000 (14:58 +0000)
This is not needed and has the potential to loose
information if the sddl code wouldn't have all features
implemented.

No intended change in behaviour.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14927

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
python/samba/netcmd/gpo.py

index 96fce917f0f80d06a31127a9ea22983515bdf577..d22404dd851cfa83f193cc3aa6f310bb2825a7f6 100644 (file)
@@ -1503,8 +1503,7 @@ class cmd_create(GPOCommand):
 
             # Create a file system security descriptor
             domain_sid = security.dom_sid(self.samdb.get_domain_sid())
-            sddl = dsacl2fsacl(ds_sd, domain_sid)
-            fs_sd = security.descriptor.from_sddl(sddl, domain_sid)
+            fs_sd = dsacl2fsacl(ds_sd, domain_sid, as_sddl=False)
 
             # Copy GPO directory
             create_directory_hier(conn, sharepath)