ALSA: vxpocket: Fix resource leak in vxpocket_probe error path

When vxpocket_config() fails, vxpocket_probe() returns the error code
directly without freeing the sound card resources allocated by
snd_card_new(), which leads to a memory leak.

Add proper error handling to free the sound card and clear the
allocation bit when vxpocket_config() fails.

Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251215042652.695-1-vulab@iscas.ac.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/pcmcia/vx/vxpocket.c b/sound/pcmcia/vx/vxpocket.c
index 2e09f2a513a6a07a4ae49e6fbdd733be0943cee6..9a5c9aa8eec4a02957ce2f7d4cbc80d001356635 100644 (file)
--- a/sound/pcmcia/vx/vxpocket.c
+++ b/sound/pcmcia/vx/vxpocket.c
@@ -284,7 +284,13 @@ static int vxpocket_probe(struct pcmcia_device *p_dev)
 
        vxp->p_dev = p_dev;
 
-       return vxpocket_config(p_dev);
+       err = vxpocket_config(p_dev);
+       if (err < 0) {
+               card_alloc &= ~(1 << i);
+               snd_card_free(card);
+               return err;
+       }
+       return 0;
 }
 
 static void vxpocket_detach(struct pcmcia_device *link)