]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: Fix Coverity ID 242718 Uninitialized scalar variable
authorVolker Lendecke <vl@samba.org>
Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)
committerVolker Lendecke <vl@samba.org>
Thu, 10 May 2012 07:11:57 +0000 (09:11 +0200)
In an error path we are closing user_pol without opening it

source3/rpcclient/cmd_samr.c

index 196e40fd3349c7e368a4ed84bed8bd711b45002c..ebc13c3334734686dc844992636f061008a059f8 100644 (file)
@@ -2703,7 +2703,8 @@ static NTSTATUS cmd_samr_chgpasswd(struct rpc_pipe_client *cli,
                                   TALLOC_CTX *mem_ctx,
                                   int argc, const char **argv)
 {
-       struct policy_handle connect_pol, domain_pol, user_pol;
+       struct policy_handle connect_pol, domain_pol;
+       struct policy_handle user_pol = { 0, };
        NTSTATUS status, result;
        const char *user, *oldpass, *newpass;
        uint32 access_mask = MAXIMUM_ALLOWED_ACCESS;