]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/msm/dp: remove debugging prints with internal struct phy state
authorVladimir Oltean <vladimir.oltean@nxp.com>
Fri, 27 Mar 2026 18:46:53 +0000 (20:46 +0200)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Wed, 1 Apr 2026 15:02:18 +0000 (18:02 +0300)
These do not provide much value, and will become hard to maintain once
the Generic PHY framework starts hiding the contents of struct phy from
consumers.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/714986/
Link: https://lore.kernel.org/r/20260327184706.1600329-16-vladimir.oltean@nxp.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/msm/dp/dp_ctrl.c

index 5fc261191cb789dbfdd5cc51b0d62bb592ddfb06..4fd987bb7dadce1744ed266c19b07506f19b919e 100644 (file)
@@ -1928,9 +1928,6 @@ void msm_dp_ctrl_phy_init(struct msm_dp_ctrl *msm_dp_ctrl)
 
        msm_dp_ctrl_phy_reset(ctrl);
        phy_init(phy);
-
-       drm_dbg_dp(ctrl->drm_dev, "phy=%p init=%d power_on=%d\n",
-                       phy, phy->init_count, phy->power_count);
 }
 
 void msm_dp_ctrl_phy_exit(struct msm_dp_ctrl *msm_dp_ctrl)
@@ -1943,8 +1940,6 @@ void msm_dp_ctrl_phy_exit(struct msm_dp_ctrl *msm_dp_ctrl)
 
        msm_dp_ctrl_phy_reset(ctrl);
        phy_exit(phy);
-       drm_dbg_dp(ctrl->drm_dev, "phy=%p init=%d power_on=%d\n",
-                       phy, phy->init_count, phy->power_count);
 }
 
 static int msm_dp_ctrl_reinitialize_mainlink(struct msm_dp_ctrl_private *ctrl)
@@ -1996,8 +1991,6 @@ static int msm_dp_ctrl_deinitialize_mainlink(struct msm_dp_ctrl_private *ctrl)
        phy_exit(phy);
        phy_init(phy);
 
-       drm_dbg_dp(ctrl->drm_dev, "phy=%p init=%d power_on=%d\n",
-                       phy, phy->init_count, phy->power_count);
        return 0;
 }
 
@@ -2588,9 +2581,6 @@ void msm_dp_ctrl_off_link_stream(struct msm_dp_ctrl *msm_dp_ctrl)
        /* aux channel down, reinit phy */
        phy_exit(phy);
        phy_init(phy);
-
-       drm_dbg_dp(ctrl->drm_dev, "phy=%p init=%d power_on=%d\n",
-                       phy, phy->init_count, phy->power_count);
 }
 
 void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl)
@@ -2606,13 +2596,7 @@ void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl)
        dev_pm_opp_set_rate(ctrl->dev, 0);
        msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);
 
-       DRM_DEBUG_DP("Before, phy=%p init_count=%d power_on=%d\n",
-               phy, phy->init_count, phy->power_count);
-
        phy_power_off(phy);
-
-       DRM_DEBUG_DP("After, phy=%p init_count=%d power_on=%d\n",
-               phy, phy->init_count, phy->power_count);
 }
 
 void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl)
@@ -2638,8 +2622,6 @@ void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl)
        msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);
 
        phy_power_off(phy);
-       drm_dbg_dp(ctrl->drm_dev, "phy=%p init=%d power_on=%d\n",
-                       phy, phy->init_count, phy->power_count);
 }
 
 irqreturn_t msm_dp_ctrl_isr(struct msm_dp_ctrl *msm_dp_ctrl)