]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mctp i2c: initialise event handler read bytes
authorMatt Johnston <matt@codeconstruct.com.au>
Tue, 13 Jan 2026 09:01:16 +0000 (17:01 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 17 Jan 2026 23:14:18 +0000 (15:14 -0800)
Set a 0xff value for i2c reads of an mctp-i2c device. Otherwise reads
will return "val" from the i2c bus driver. For i2c-aspeed and
i2c-npcm7xx that is a stack uninitialised u8.

Tested with "i2ctransfer -y 1 r10@0x34" where 0x34 is a mctp-i2c
instance, now it returns all 0xff.

Fixes: f5b8abf9fc3d ("mctp i2c: MCTP I2C binding driver")
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Link: https://patch.msgid.link/20260113-mctp-read-fix-v1-1-70c4b59c741c@codeconstruct.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/mctp/mctp-i2c.c

index ecda1cc36391ce50a6b28e6a9e13c3b344f8f993..8043b57bdf25095b3b4e6bacd3abbc6f8952acfe 100644 (file)
@@ -243,7 +243,10 @@ static int mctp_i2c_slave_cb(struct i2c_client *client,
 
        switch (event) {
        case I2C_SLAVE_READ_REQUESTED:
+       case I2C_SLAVE_READ_PROCESSED:
+               /* MCTP I2C transport only uses writes */
                midev->rx_pos = 0;
+               *val = 0xff;
                break;
        case I2C_SLAVE_WRITE_RECEIVED:
                if (midev->rx_pos < MCTP_I2C_BUFSZ) {