]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Fix a unit test bug for passing arguments to tor_parse_ulong.
authorNick Mathewson <nickm@torproject.org>
Wed, 7 Sep 2016 00:29:55 +0000 (20:29 -0400)
committerNick Mathewson <nickm@torproject.org>
Wed, 7 Sep 2016 00:29:55 +0000 (20:29 -0400)
We wanted to make sure -50 was a bad input, but instead we were
passing a 'min' that was greater than 'max'.

src/test/test_util.c

index 6836c01d31df66fa9ac2cf551ddf2a061482250e..974caeef054874d0b17cd131ea0fe5d1dce842f7 100644 (file)
@@ -2001,9 +2001,11 @@ test_util_parse_integer(void *arg)
   tt_int_op(10UL,OP_EQ, tor_parse_ulong("10",10,10,100,NULL,NULL));
   tt_int_op(0UL,OP_EQ, tor_parse_ulong("8",8,0,100,NULL,NULL));
   tt_int_op(50UL,OP_EQ, tor_parse_ulong("50",10,50,100,NULL,NULL));
-  tt_int_op(0UL,OP_EQ, tor_parse_ulong("-50",10,-100,100,NULL,NULL));
+  tt_int_op(0UL,OP_EQ, tor_parse_ulong("-50",10,0,100,NULL,NULL));
   tt_int_op(0UL,OP_EQ, tor_parse_ulong("50",-1,50,100,&i,NULL));
   tt_int_op(0,OP_EQ, i);
+  tt_int_op(0UL,OP_EQ, tor_parse_ulong("-50",10,0,100,&i,NULL));
+  tt_int_op(0,OP_EQ, i);
 
   /* Test parse_uint64 */
   tt_assert(U64_LITERAL(10) == tor_parse_uint64("10 x",10,0,100, &i, &cp));