]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: tps65086: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 2 Jul 2025 09:14:09 +0000 (11:14 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 7 Jul 2025 07:45:30 +0000 (09:45 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250702-gpiochip-set-rv-gpio-round3-v1-8-0d23be74f71d@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-tps65086.c

index 8f5827554e1e89b2cc2cac0e43521246fc986408..08fa061b73efcffd5f68724ae3fdc54515d45adb 100644 (file)
@@ -37,10 +37,8 @@ static int tps65086_gpio_direction_output(struct gpio_chip *chip,
        struct tps65086_gpio *gpio = gpiochip_get_data(chip);
 
        /* Set the initial value */
-       regmap_update_bits(gpio->tps->regmap, TPS65086_GPOCTRL,
-                          BIT(4 + offset), value ? BIT(4 + offset) : 0);
-
-       return 0;
+       return regmap_update_bits(gpio->tps->regmap, TPS65086_GPOCTRL,
+                                 BIT(4 + offset), value ? BIT(4 + offset) : 0);
 }
 
 static int tps65086_gpio_get(struct gpio_chip *chip, unsigned offset)
@@ -55,13 +53,13 @@ static int tps65086_gpio_get(struct gpio_chip *chip, unsigned offset)
        return val & BIT(4 + offset);
 }
 
-static void tps65086_gpio_set(struct gpio_chip *chip, unsigned offset,
-                             int value)
+static int tps65086_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                            int value)
 {
        struct tps65086_gpio *gpio = gpiochip_get_data(chip);
 
-       regmap_update_bits(gpio->tps->regmap, TPS65086_GPOCTRL,
-                          BIT(4 + offset), value ? BIT(4 + offset) : 0);
+       return regmap_update_bits(gpio->tps->regmap, TPS65086_GPOCTRL,
+                                 BIT(4 + offset), value ? BIT(4 + offset) : 0);
 }
 
 static const struct gpio_chip template_chip = {
@@ -71,7 +69,7 @@ static const struct gpio_chip template_chip = {
        .direction_input        = tps65086_gpio_direction_input,
        .direction_output       = tps65086_gpio_direction_output,
        .get                    = tps65086_gpio_get,
-       .set                    = tps65086_gpio_set,
+       .set_rv                 = tps65086_gpio_set,
        .base                   = -1,
        .ngpio                  = 4,
        .can_sleep              = true,