]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virfirewall: virFirewallAddRuleFullV: Remove OOM check from VIR_APPEND_ELEMENT
authorPeter Krempa <pkrempa@redhat.com>
Tue, 23 Feb 2021 16:38:18 +0000 (17:38 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 2 Mar 2021 08:50:19 +0000 (09:50 +0100)
VIR_APPEND_ELEMENT_COPY will abort the program on OOM so there's no need
to check.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
src/util/virfirewall.c

index 66b33d4a917e5dec4d3ba8d5ac8ccf53ecb57cbb..bbeb87e72d5b6e487c85be691373dc77e26ef206 100644 (file)
@@ -315,24 +315,17 @@ virFirewallAddRuleFullV(virFirewallPtr firewall,
         ADD_ARG(rule, str);
 
     if (group->addingRollback) {
-        if (VIR_APPEND_ELEMENT_COPY(group->rollback,
-                                    group->nrollback,
-                                    rule) < 0)
-            goto no_memory;
+        ignore_value(VIR_APPEND_ELEMENT_COPY(group->rollback,
+                                             group->nrollback,
+                                             rule));
     } else {
-        if (VIR_APPEND_ELEMENT_COPY(group->action,
-                                    group->naction,
-                                    rule) < 0)
-            goto no_memory;
+        ignore_value(VIR_APPEND_ELEMENT_COPY(group->action,
+                                             group->naction,
+                                             rule));
     }
 
 
     return rule;
-
- no_memory:
-    firewall->err = ENOMEM;
-    virFirewallRuleFree(rule);
-    return NULL;
 }