go test: don't rely on undefined append behavior

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

diff --git a/contrib/external-tests/go/main.go b/contrib/external-tests/go/main.go
index 8e3c19519ea121690bb53a2edb5d9f1d8145f60f..c1aa29375eec3d80db0d5ca40371e06cddb20fd2 100644 (file)
--- a/contrib/external-tests/go/main.go
+++ b/contrib/external-tests/go/main.go
@@ -118,15 +118,13 @@ func main() {
                Dst:      net.IPv4(10, 189, 129, 1),
        }).Marshal()
        binary.BigEndian.PutUint16(pingHeader[2:], uint16(ipv4.HeaderLen+len(pingMessage))) // fix the length endianness on BSDs
-       binary.BigEndian.PutUint16(pingHeader[10:], ipChecksum(append(pingHeader, pingMessage...)))
-       if err != nil {
-               panic(err)
-       }
+       pingData := append(pingHeader, pingMessage...)
+       binary.BigEndian.PutUint16(pingData[10:], ipChecksum(pingData))
        pingPacket := make([]byte, 13)
        pingPacket[0] = 4 // Type: Data
        binary.LittleEndian.PutUint32(pingPacket[1:], theirIndex)
        binary.LittleEndian.PutUint64(pingPacket[5:], 0) // Nonce
-       pingPacket = sendCipher.Encrypt(pingPacket, nil, append(pingHeader, pingMessage...))
+       pingPacket = sendCipher.Encrypt(pingPacket, nil, pingData)
        if _, err := conn.Write(pingPacket); err != nil {
                log.Fatalf("error writing ping message: %s", err)
        }