]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mn10300/misalignment: Use SIGSEGV SEGV_MAPERR to report a failed user copy
authorEric W. Biederman <ebiederm@xmission.com>
Tue, 1 Aug 2017 10:02:38 +0000 (05:02 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 31 May 2018 23:30:08 +0000 (00:30 +0100)
commit 6ac1dc736b323011a55ecd1fc5897c24c4f77cbd upstream.

Setting si_code to 0 is the same a setting si_code to SI_USER which is definitely
not correct.  With si_code set to SI_USER si_pid and si_uid will be copied to
userspace instead of si_addr.  Which is very wrong.

So fix this by using a sensible si_code (SEGV_MAPERR) for this failure.

Fixes: b920de1b77b7 ("mn10300: add the MN10300/AM33 architecture to the kernel")
Cc: David Howells <dhowells@redhat.com>
Cc: Masakazu Urade <urade.masakazu@jp.panasonic.com>
Cc: Koichi Yasutake <yasutake.koichi@jp.panasonic.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/mn10300/mm/misalignment.c

index f9bb8cb1c14ad0e044320f53efca5431927e8121..c91d8add40c0d60fe41f4352371d8ed6e197bb6b 100644 (file)
@@ -438,7 +438,7 @@ transfer_failed:
 
        info.si_signo   = SIGSEGV;
        info.si_errno   = 0;
-       info.si_code    = 0;
+       info.si_code    = SEGV_MAPERR;
        info.si_addr    = (void *) regs->pc;
        force_sig_info(SIGSEGV, &info, current);
        return;