]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
libstdc++: Fix tests relying on operator new/delete overload
authorFrançois Dumont <fdumont@gcc.gnu.org>
Mon, 21 Aug 2023 05:02:06 +0000 (07:02 +0200)
committerFrançois Dumont <fdumont@gcc.gnu.org>
Wed, 23 Aug 2023 04:35:24 +0000 (06:35 +0200)
Fix tests that are checking for an expected allocation plan. They are failing if
an allocation is taking place outside the test main.

libstdc++-v3/ChangeLog

* testsuite/util/replacement_memory_operators.h
(counter::scope): New, capture and reset counter count at construction and
restore it at destruction.
(counter::check_new): Add scope instantiation.
* testsuite/23_containers/unordered_map/96088.cc (main):
Add counter::scope instantiation.
* testsuite/23_containers/unordered_multimap/96088.cc (main): Likewise.
* testsuite/23_containers/unordered_multiset/96088.cc (main): Likewise.
* testsuite/23_containers/unordered_set/96088.cc (main): Likewise.
* testsuite/ext/malloc_allocator/deallocate_local.cc (main): Likewise.
* testsuite/ext/new_allocator/deallocate_local.cc (main): Likewise.
* testsuite/ext/throw_allocator/deallocate_local.cc (main): Likewise.
* testsuite/ext/pool_allocator/allocate_chunk.cc (started): New global.
(operator new(size_t)): Check started.
(main): Set/Unset started.
* testsuite/17_intro/no_library_allocation.cc: New test case.

libstdc++-v3/testsuite/17_intro/no_library_allocation.cc [new file with mode: 0644]
libstdc++-v3/testsuite/23_containers/unordered_map/96088.cc
libstdc++-v3/testsuite/23_containers/unordered_multimap/96088.cc
libstdc++-v3/testsuite/23_containers/unordered_multiset/96088.cc
libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc
libstdc++-v3/testsuite/ext/malloc_allocator/deallocate_local.cc
libstdc++-v3/testsuite/ext/new_allocator/deallocate_local.cc
libstdc++-v3/testsuite/ext/pool_allocator/allocate_chunk.cc
libstdc++-v3/testsuite/ext/throw_allocator/deallocate_local.cc
libstdc++-v3/testsuite/util/replacement_memory_operators.h

diff --git a/libstdc++-v3/testsuite/17_intro/no_library_allocation.cc b/libstdc++-v3/testsuite/17_intro/no_library_allocation.cc
new file mode 100644 (file)
index 0000000..278d475
--- /dev/null
@@ -0,0 +1,8 @@
+#include <testsuite_hooks.h>
+#include <replacement_memory_operators.h>
+
+int main()
+{
+  VERIFY( __gnu_test::counter::count() == 0 );
+  return 0;
+}
index c6d50c20fbf6593a340e7e818eac9533e5295fcb..cdf00c93d80e4ada77a0ef1bd643cc33a4cf6ef4 100644 (file)
@@ -268,6 +268,7 @@ test03()
 int
 main()
 {
+  __gnu_test::counter::scope s;
   test01();
   test02();
   test11();
index 214bc91a559a0c5995d8a494c2bb212b18c8a349..d8b9a40c1746c51e66205712682de01e7431f174 100644 (file)
@@ -61,6 +61,7 @@ test02()
 int
 main()
 {
+  __gnu_test::counter::scope s;
   test01();
   test02();
   return 0;
index 838ce8d5bc531767b1c1533d068b13f41540c897..db17cda0ddd8c2b71b1537fdb77a763ba8c19ff6 100644 (file)
@@ -61,6 +61,7 @@ test02()
 int
 main()
 {
+  __gnu_test::counter::scope s;
   test01();
   test02();
   return 0;
index 0f7dce2b38c52f52cc6edb96d0b8dec75e191bba..831f2aa1210cab8bd25e7ed791199f3af3ee8623 100644 (file)
@@ -269,6 +269,7 @@ test03()
 int
 main()
 {
+  __gnu_test::counter::scope s;
   test01();
   test02();
   test11();
index 79b583bd716c73a9dea33aee77c4a5fdfcfe27d1..29eb4032ad9b5000e1f2c2241ab11e683cbc39a7 100644 (file)
@@ -27,6 +27,7 @@ typedef std::basic_string<char_t, traits_t, allocator_t> string_t;
 
 int main()
 {
+  __gnu_test::counter::scope s;
   {
     string_t s;
     s += "bayou bend";
@@ -34,5 +35,6 @@ int main()
 
   if (__gnu_test::counter::count() != 0)
     throw std::runtime_error("count not zero");
+
   return 0;
 }
index fcde46e6e10ccd28b80d5ed7b5e570d474d6efbf..e4a94604f438a3c003cfbbc20652e730a030456b 100644 (file)
@@ -27,6 +27,7 @@ typedef std::basic_string<char_t, traits_t, allocator_t> string_t;
 
 int main()
 {
+  __gnu_test::counter::scope s;
   {
     string_t s;
     s += "bayou bend";
@@ -34,5 +35,6 @@ int main()
 
   if (__gnu_test::counter::count() != 0)
     throw std::runtime_error("count not zero");
+
   return 0;
 }
index 17f8e3c7dcbc28cba90adff2b4addc53db9448eb..b11b450bf9e35680df21d0815fca54363153296b 100644 (file)
@@ -32,16 +32,29 @@ struct big
   char c[64];
 };
 
+bool started = false;
+
 void*
 operator new(size_t n) THROW(std::bad_alloc)
 {
-  static bool first = true;
-  if (!first)
-    throw std::bad_alloc();
-  first = false;
+  if (started)
+    {
+      static bool first = true;
+      if (!first)
+       throw std::bad_alloc();
+      first = false;
+    }
+
   return std::malloc(n);
 }
 
+void
+operator delete(void* p) throw()
+{
+  if (p)
+    std::free(p);
+}
+
 // http://gcc.gnu.org/ml/libstdc++/2004-10/msg00098.html
 void test01()
 {
@@ -59,5 +72,7 @@ void test01()
 
 int main()
 {
+  started = true;
   test01();
+  started = false;
 }
index c6fd3538b825d62c99acd9c3991efa826821fbf9..2a675e8b6b47e4699c10f8643ee88e10b6252ebb 100644 (file)
@@ -30,6 +30,7 @@ typedef std::basic_string<char_t, traits_t, allocator_t> string_t;
 
 int main()
 {
+  __gnu_test::counter::scope s;
   {
     string_t s;
     s += "bayou bend";
index 6b1b3a82364ccf54a206585ac0a6b12a4de07c98..6f19fbb8f6f690b159bb509ebea549e507a7f2a6 100644 (file)
@@ -75,12 +75,32 @@ namespace __gnu_test
       counter& cntr = get();
       cntr._M_increments = cntr._M_decrements = 0;
     }
+
+    struct scope
+    {
+      scope() : _M_count(counter::count())
+      { counter::get()._M_count = 0; }
+      ~scope()
+      { counter::get()._M_count = _M_count; }
+
+    private:
+      std::size_t _M_count;
+
+#if __cplusplus >= 201103L
+      scope(const scope&) = delete;
+      scope& operator=(const scope&) = delete;
+#else
+      scope(const scope&);
+      scope& operator=(const scope&);
+#endif
+    };
   };
 
   template<typename Alloc, bool uses_global_new>
     bool
     check_new(Alloc a = Alloc())
     {
+      __gnu_test::counter::scope s;
       __gnu_test::counter::exceptions(false);
       (void) a.allocate(10);
       const bool __b((__gnu_test::counter::count() > 0) == uses_global_new);