]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
leds: pca955x: Use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 23 Apr 2025 07:53:51 +0000 (09:53 +0200)
committerLee Jones <lee@kernel.org>
Wed, 14 May 2025 08:24:59 +0000 (09:24 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250423-gpiochip-set-rv-leds-v1-2-2f42d8fbb525@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-pca955x.c

index 24a40a1cdb15fcbcd79aab88ac66eaad4b05b052..42fe056b1c7469ec38762c30197ef7107443f021 100644 (file)
@@ -495,10 +495,10 @@ static int pca955x_set_value(struct gpio_chip *gc, unsigned int offset,
        return pca955x_led_set(&led->led_cdev, PCA955X_GPIO_LOW);
 }
 
-static void pca955x_gpio_set_value(struct gpio_chip *gc, unsigned int offset,
-                                  int val)
+static int pca955x_gpio_set_value(struct gpio_chip *gc, unsigned int offset,
+                                 int val)
 {
-       pca955x_set_value(gc, offset, val);
+       return pca955x_set_value(gc, offset, val);
 }
 
 static int pca955x_gpio_get_value(struct gpio_chip *gc, unsigned int offset)
@@ -737,7 +737,7 @@ static int pca955x_probe(struct i2c_client *client)
        pca955x->gpio.label = "gpio-pca955x";
        pca955x->gpio.direction_input = pca955x_gpio_direction_input;
        pca955x->gpio.direction_output = pca955x_gpio_direction_output;
-       pca955x->gpio.set = pca955x_gpio_set_value;
+       pca955x->gpio.set_rv = pca955x_gpio_set_value;
        pca955x->gpio.get = pca955x_gpio_get_value;
        pca955x->gpio.request = pca955x_gpio_request_pin;
        pca955x->gpio.free = pca955x_gpio_free_pin;