]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix missing server socket detach in TLS accept error path
authorOndřej Surý <ondrej@isc.org>
Sat, 14 Mar 2026 11:54:27 +0000 (12:54 +0100)
committerOndřej Surý <ondrej@isc.org>
Sat, 14 Mar 2026 12:58:32 +0000 (13:58 +0100)
When TLS creation fails in tlslisten_acceptcb(), tlssock->server
was not detached before detaching tlssock itself.

lib/isc/netmgr/tlsstream.c

index 39c29c9ebf92004a3f6eb249d35a2955ef9dd783..3a9ab1dfbf6cefcd54dcf1fbcf631a4e6520c879 100644 (file)
@@ -932,6 +932,7 @@ tlslisten_acceptcb(isc_nmhandle_t *handle, isc_result_t result, void *cbarg) {
        if (tlssock->tlsstream.tls == NULL) {
                tlssock->closed = true;
                isc_tlsctx_free(&tlssock->tlsstream.ctx);
+               isc__nmsocket_detach(&tlssock->server);
                isc__nmsocket_detach(&tlssock);
                return ISC_R_TLSERROR;
        }