CLEANUP: resolvers: do not export resolv_purge_resolution_answer_records()

This code is dangerous enough that we certainly don't want external code
to ever approach it, let's not export unnecessary functions like this one.
It was made static and a comment was added about its purpose.

diff --git a/include/haproxy/resolvers.h b/include/haproxy/resolvers.h
index 70211a82b55ccb718222649b6391401c3b434b25..6030bb662fc53555de2a3a56f928d9a7edb15806 100644 (file)
--- a/include/haproxy/resolvers.h
+++ b/include/haproxy/resolvers.h
@@ -48,7 +48,6 @@ int resolv_get_ip_from_response(struct resolv_response *r_res,
                              void **newip, short *newip_sin_family,
                              struct server *owner);
 
-void resolv_purge_resolution_answer_records(struct resolv_resolution *resolution);
 int resolv_link_resolution(void *requester, int requester_type, int requester_locked);
 void resolv_unlink_resolution(struct resolv_requester *requester, int safe);
 void resolv_detach_from_resolution_answer_items(struct resolv_resolution *res,  struct resolv_requester *req, int safe);

diff --git a/src/resolvers.c b/src/resolvers.c
index 44305fc408e88c94baf310d54226e5f396be4193..15895d58064092ec37a35acd93f05a6d19b0c985 100644 (file)
--- a/src/resolvers.c
+++ b/src/resolvers.c
@@ -1786,7 +1786,8 @@ static struct resolv_resolution *resolv_pick_resolution(struct resolvers *resolv
        return res;
 }
 
-void resolv_purge_resolution_answer_records(struct resolv_resolution *resolution)
+/* deletes and frees all answer_items from the resolution's answer_list */
+static void resolv_purge_resolution_answer_records(struct resolv_resolution *resolution)
 {
        struct resolv_answer_item *item, *itemback;