vala: Don't use possibly uninitialized backing field of package_name

Don't check _package_name directly, which may be null at the time
installed_version is accessed. This fixes a bug where Vala wouldn't
generate errors when using symbols that are unavailable for a package
version.

Introduced by 7f0e90a5c34f437b7ab8f9197a9d42fc835b1a60

Fixes https://gitlab.gnome.org/GNOME/vala/issues/971

diff --git a/vala/valasourcefile.vala b/vala/valasourcefile.vala
index 2e270a06c5ee9e3ef2d05796f1f97d4120d3f24b..ac9000f49f2aa701db42ec28eea181ab430e2577 100644 (file)
--- a/vala/valasourcefile.vala
+++ b/vala/valasourcefile.vala
@@ -70,7 +70,7 @@ public class Vala.SourceFile {
 
                        _version_requested = true;
 
-                       if (_package_name != null) {
+                       if (package_name != null) {
                                _installed_version = context.pkg_config_modversion (package_name);
                        }