]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
WIP binary fix
authorRico Tzschichholz <ricotz@ubuntu.com>
Sat, 13 Apr 2019 18:52:35 +0000 (20:52 +0200)
committerRico Tzschichholz <ricotz@ubuntu.com>
Fri, 19 Apr 2019 13:29:51 +0000 (15:29 +0200)
vala/valabinaryexpression.vala

index 2dda5017f9fdd33a55e40c1c33fe1e90859d8ee7..af15596f3a9997199833c35c837c8e7dcfcb3e87 100644 (file)
@@ -441,16 +441,18 @@ public class Vala.BinaryExpression : Expression {
        }
 
        public override void get_defined_variables (Collection<Variable> collection) {
-               //FIXME Handled special in FlowAnalyzer
-               if (operator != BinaryOperator.AND && operator != BinaryOperator.OR) {
+               if (operator == BinaryOperator.OR) {
+                       left.get_defined_variables (collection);
+               } else {
                        left.get_defined_variables (collection);
                        right.get_defined_variables (collection);
                }
        }
 
        public override void get_used_variables (Collection<Variable> collection) {
-               //FIXME Handled special in FlowAnalyzer
-               if (operator != BinaryOperator.AND && operator != BinaryOperator.OR) {
+               if (operator == BinaryOperator.OR) {
+                       left.get_used_variables (collection);
+               } else {
                        left.get_used_variables (collection);
                        right.get_used_variables (collection);
                }