]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
Closes #10079 - Fix a flexbug for cards on IE11
authorharry <harmanmanchanda182@gmail.com>
Sun, 28 May 2017 10:01:22 +0000 (15:31 +0530)
committerharry <harmanmanchanda182@gmail.com>
Sun, 28 May 2017 10:01:22 +0000 (15:31 +0530)
Changes
- Fix browser specific bug
- Update docs!

docs/pages/card.md
scss/components/_card.scss

index 424e1a4747d7ac628089cd23f7aa7f28167a216d..8f51e57eea06d26bed0f3bd2e36ebc42cacae1a1 100644 (file)
@@ -36,6 +36,20 @@ A card container has no padding, allowing you to place full-bleed images inside.
 </div>
 ```
 
+<div class="alert callout">
+  <p><strong>Browser Bug (IE 11 - Flexbug): </strong>On IE 11, when using the card with equalizer, there is an extra added space under each image that happens to match the original image size. The bug can be reproduced <a href="https://codepen.io/IamManchanda/pen/MmRqvN?editors=1100">here</a> on an IE11 browser. Use <code>.card-image</code> class as a parent class to an <strong>image</strong> to resolve this.</p>
+</div>
+
+<div class="docs-codepen-container">
+  <a class="codepen-logo-link" href="https://codepen.io/IamManchanda/pen/aWrWQq?editors=1100" target="_blank"><img src="{{root}}assets/img/logos/edit-in-browser.svg" class="" height="" width="" alt="edit on codepen button"></a>
+</div>
+
+```html
+<div class="card-image">
+  <img src="assets/img/generic/rectangle-1.jpg">
+</div>
+```
+
 ---
 
 ### Card Divider
index 58f87cfff3cd21b1bd10b8a7d78bad0d95a63f62..d3ba77e500d82719184baa625212b5f6fb201fb5 100644 (file)
@@ -120,4 +120,10 @@ $card-margin-bottom: $global-margin !default;
   .card-section {
     @include card-section;
   }
+
+  // For IE 11 - Flexbug
+  // https://github.com/philipwalton/flexbugs/issues/75
+  .card-image {
+    min-height: 1px;
+  }
 }