We're freeing the connection, so don't use this->next

use this = next instead

diff --git a/src/main/connection.c b/src/main/connection.c
index 61fd63267e480d8236f0abe6aad55938b1e00ea8..2438d32eab996cea9951bfb1be8037f5423e3e7b 100644 (file)
--- a/src/main/connection.c
+++ b/src/main/connection.c
@@ -388,7 +388,7 @@ static int fr_connection_pool_check(fr_connection_pool_t *fc)
 {
        int spare, spawn;
        time_t now = time(NULL);
-       fr_connection_t *this;
+       fr_connection_t *this, *next;
 
        if (fc->last_checked == now) return 1;
 
@@ -440,7 +440,8 @@ static int fr_connection_pool_check(fr_connection_pool_t *fc)
         *      Pass over all of the connections in the pool, limiting
         *      lifetime, idle time, max requests, etc.
         */
-       for (this = fc->head; this != NULL; this = this->next) {
+       for (this = fc->head; this != NULL; this = next) {
+               next = this->next;
                fr_connection_manage(fc, this, now);
        }