io_uring/io-wq: fix incorrect io_wq_for_each_worker() termination logic

commit e0392a10c9e80a3991855a81317da3039fcbe32c upstream.

A previous commit added this helper, and had it terminate if false is
returned from the handler. However, that is completely opposite, it
should abort the loop if true is returned.

Fix this up by having io_wq_for_each_worker() keep iterating as long
as false is returned, and only abort if true is returned.

Cc: stable@vger.kernel.org
Fixes: 751eedc4b4b7 ("io_uring/io-wq: move worker lists to struct io_wq_acct")
Reported-by: Lewis Campbell <info@lewiscampbell.tech>
Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/io_uring/io-wq.c b/io_uring/io-wq.c
index 1d03b2fc4b25947e3b4c58dcfa7a31be7fa603f7..55961da19f3b1d16335092f03ed33244d927e61d 100644 (file)
--- a/io_uring/io-wq.c
+++ b/io_uring/io-wq.c
@@ -951,11 +951,11 @@ static bool io_wq_for_each_worker(struct io_wq *wq,
                                  void *data)
 {
        for (int i = 0; i < IO_WQ_ACCT_NR; i++) {
-               if (!io_acct_for_each_worker(&wq->acct[i], func, data))
-                       return false;
+               if (io_acct_for_each_worker(&wq->acct[i], func, data))
+                       return true;
        }
 
-       return true;
+       return false;
 }
 
 static bool io_wq_worker_wake(struct io_worker *worker, void *data)