]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MEDIUM: connection: Don't crush context pointer location if it is a CS
authorChristopher Faulet <cfaulet@haproxy.com>
Fri, 15 Apr 2022 08:57:09 +0000 (10:57 +0200)
committerChristopher Faulet <cfaulet@haproxy.com>
Fri, 15 Apr 2022 08:57:11 +0000 (10:57 +0200)
The issue only concerns the backend connection. The conn-stream is now owned
by the stream and persists during all the stream life. Thus we must not
crush it when the backend connection is released.

It is 2.6-specific. No backport is needed.

src/connection.c

index 88e851c93256b40f00e61db4997d49abd3822089..bc47ac886c82522e6ff67253a798ed0879bffa8b 100644 (file)
@@ -501,13 +501,6 @@ void conn_free(struct connection *conn)
        pool_free(pool_head_conn_hash_node, conn->hash_node);
        conn->hash_node = NULL;
 
-       /* By convention we always place a NULL where the ctx points to if the
-        * mux is null. It may have been used to store the connection as a
-        * conn-stream's end point for example.
-        */
-       if (conn->ctx != NULL && conn->mux == NULL)
-               *(void **)conn->ctx = NULL;
-
        conn_force_unsubscribe(conn);
        pool_free(pool_head_connection, conn);
 }