]> git.ipfire.org Git - thirdparty/paperless-ngx.git/commitdiff
Fix: add some minor frontend permissions checks (#8524)
authorshamoon <4887959+shamoon@users.noreply.github.com>
Thu, 19 Dec 2024 16:08:46 +0000 (08:08 -0800)
committerGitHub <noreply@github.com>
Thu, 19 Dec 2024 16:08:46 +0000 (08:08 -0800)
src-ui/messages.xlf
src-ui/src/app/components/app-frame/app-frame.component.html
src-ui/src/app/components/app-frame/app-frame.component.ts
src-ui/src/app/services/settings.service.ts

index a4dc5cc4f688c5df18aa84d35f6004b2cd411d68..102d50ce3b0e9fb101048fbf0108ca5296ca8a2f 100644 (file)
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/app-frame/app-frame.component.ts</context>
-          <context context-type="linenumber">125</context>
+          <context context-type="linenumber">132</context>
         </context-group>
       </trans-unit>
       <trans-unit id="2991443309752293110" datatype="html">
         <source>Sidebar views updated</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/app-frame/app-frame.component.ts</context>
-          <context context-type="linenumber">209</context>
+          <context context-type="linenumber">216</context>
         </context-group>
       </trans-unit>
       <trans-unit id="3547923076537026828" datatype="html">
         <source>Error updating sidebar views</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/app-frame/app-frame.component.ts</context>
-          <context context-type="linenumber">212</context>
+          <context context-type="linenumber">219</context>
         </context-group>
       </trans-unit>
       <trans-unit id="2526035785704676448" datatype="html">
         <source>An error occurred while saving update checking settings.</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/app-frame/app-frame.component.ts</context>
-          <context context-type="linenumber">233</context>
+          <context context-type="linenumber">240</context>
         </context-group>
       </trans-unit>
       <trans-unit id="4580988005648117665" datatype="html">
         <source>You can restart the tour from the settings page.</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/services/settings.service.ts</context>
-          <context context-type="linenumber">655</context>
+          <context context-type="linenumber">661</context>
         </context-group>
       </trans-unit>
       <trans-unit id="3852289441366561594" datatype="html">
index 2354b68fc565243e8f67f776bc1dcc7f6df1976e..442f9f366e275a1a7ee4cde7f5b967bbeafd288b 100644 (file)
                         </a>
                       }
                     } @else {
-                      <a class="small text-decoration-none" routerLink="/settings" fragment="update-checking"
+                      <a  *pngxIfPermissions="{ action: PermissionAction.Change, type: PermissionType.UISettings }" class="small text-decoration-none" routerLink="/settings" fragment="update-checking"
                         [ngbPopover]="updateCheckingNotEnabledPopContent" popoverClass="shadow" triggers="mouseenter"
                         container="body">
                         <i-bs width="1.2em" height="1.2em" name="info-circle"></i-bs>
index efa42f38201f48eb2a7d175042d63404fd73c4df..92efd76283efcb914788426dde5ba0d2f8b1bae2 100644 (file)
@@ -81,7 +81,14 @@ export class AppFrameComponent
     if (this.settingsService.get(SETTINGS_KEYS.UPDATE_CHECKING_ENABLED)) {
       this.checkForUpdates()
     }
-    this.tasksService.reload()
+    if (
+      this.permissionsService.currentUserCan(
+        PermissionAction.View,
+        PermissionType.PaperlessTask
+      )
+    ) {
+      this.tasksService.reload()
+    }
 
     this.djangoMessagesService.get().forEach((message) => {
       switch (message.level) {
index e270adc8177dd2217eff6985d02bfa10c216610e..9e1b3e360e42e75edf71c5099d1dd3b8d0835bd3 100644 (file)
@@ -646,7 +646,13 @@ export class SettingsService {
 
   completeTour() {
     const tourCompleted = this.get(SETTINGS_KEYS.TOUR_COMPLETE)
-    if (!tourCompleted) {
+    if (
+      !tourCompleted &&
+      this.permissionsService.currentUserCan(
+        PermissionAction.Change,
+        PermissionType.UISettings
+      )
+    ) {
       this.set(SETTINGS_KEYS.TOUR_COMPLETE, true)
       this.storeSettings()
         .pipe(first())