repogit: add prototypes for error checking

And add a note to remove git_commit_title

diff --git a/lib/PublicInbox/RepoGit.pm b/lib/PublicInbox/RepoGit.pm
index f7bf0b9d537683085ab16f020d04a0dfffc87cbf..b44457ca4dacbec93a33b4fb339312818c233e68 100644 (file)
--- a/lib/PublicInbox/RepoGit.pm
+++ b/lib/PublicInbox/RepoGit.pm
@@ -19,7 +19,7 @@ my %GIT_ESC = (
        v => "\013",
 );
 
-sub git_unquote {
+sub git_unquote ($) {
        my ($s) = @_;
        return $s unless ($s =~ /\A"(.*)"\z/);
        $s = $1;
@@ -28,7 +28,8 @@ sub git_unquote {
        $s;
 }
 
-sub git_commit_title {
+# Remove, hilariously slow
+sub git_commit_title ($$) {
        my ($git, $obj) = @_; # PublicInbox::Git, $sha1hex
        my $rv;
        eval {
@@ -39,7 +40,7 @@ sub git_commit_title {
 }
 
 # example inputs: "HEAD -> master", "tag: v1.0.0",
-sub git_dec_links {
+sub git_dec_links ($$) {
        my ($rel, $D) = @_;
        my @l;
        foreach (split /, /, $D) {