]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
emit an error for type or const parameters on foreign items
authorRyutaro Okada <1015ryu88@gmail.com>
Fri, 14 Mar 2025 12:25:03 +0000 (21:25 +0900)
committerPhilip Herron <philip.herron@embecosm.com>
Wed, 19 Mar 2025 10:07:47 +0000 (10:07 +0000)
gcc/rust/ChangeLog:

* typecheck/rust-hir-type-check-implitem.cc (TypeCheckTopLevelExternItem::visit):
emit an error for type or const parameters on foreign items

gcc/testsuite/ChangeLog:

* rust/compile/extern_generics.rs: New test.

Signed-off-by: Ryutaro Okada <1015ryu88@gmail.com>
gcc/rust/typecheck/rust-hir-type-check-implitem.cc
gcc/testsuite/rust/compile/extern_generics.rs [new file with mode: 0644]

index 31164c1358a0a155092aad6bb94c801ad497fab0..18ac0dd5c2d9404c45d9d909908166a5fadc07cb 100644 (file)
@@ -86,9 +86,20 @@ TypeCheckTopLevelExternItem::visit (HIR::ExternalFunctionItem &function)
            case HIR::GenericParam::GenericKind::CONST:
              // FIXME: Skipping Lifetime and Const completely until better
              // handling.
+             if (parent.get_abi () != Rust::ABI::INTRINSIC)
+               {
+                 rust_error_at (function.get_locus (), ErrorCode::E0044,
+                                "foreign items may not have const parameters");
+               }
              break;
 
              case HIR::GenericParam::GenericKind::TYPE: {
+               if (parent.get_abi () != Rust::ABI::INTRINSIC)
+                 {
+                   rust_error_at (
+                     function.get_locus (), ErrorCode::E0044,
+                     "foreign items may not have type parameters");
+                 }
                auto param_type
                  = TypeResolveGenericParam::Resolve (*generic_param);
                context->insert_type (generic_param->get_mappings (),
diff --git a/gcc/testsuite/rust/compile/extern_generics.rs b/gcc/testsuite/rust/compile/extern_generics.rs
new file mode 100644 (file)
index 0000000..26f97a6
--- /dev/null
@@ -0,0 +1,8 @@
+#[lang="sized"]
+trait Sized {}
+
+
+// E0044
+fn main() {
+extern "C" { fn some_func<T>(x: T); } // { dg-error "foreign items may not have type parameters .E0044." }
+}
\ No newline at end of file