]> git.ipfire.org Git - thirdparty/knot-dns.git/commitdiff
tests-extra: improve Zonefile.dnssec_verify() logging
authorDaniel Salzman <daniel.salzman@nic.cz>
Thu, 27 Jun 2019 07:58:54 +0000 (09:58 +0200)
committerDaniel Salzman <daniel.salzman@nic.cz>
Thu, 27 Jun 2019 07:58:54 +0000 (09:58 +0200)
tests-extra/tools/dnstest/server.py
tests-extra/tools/dnstest/zonefile.py

index 80cf8ef31652092b89f88f5b0e57837379946e7b..82bf33e52200653dc51ae56c496608a6c562e7e6 100644 (file)
@@ -657,7 +657,7 @@ class Server(object):
 
         self.zones[zone.name].zfile.backup()
 
-    def zone_verify(self, zone, bind_check=None, ldns_check=None):
+    def zone_verify(self, zone, bind_check=True, ldns_check=True):
         zone = zone_arg_check(zone)
 
         self.zones[zone.name].zfile.dnssec_verify(bind_check, ldns_check)
index c35ea3e7825f1e84257cafdebc20b44ca35b6547..dfd78021af98e21ccb419491b1853e821059d943 100644 (file)
@@ -129,8 +129,10 @@ class ZoneFile(object):
 
             if cmd.returncode != 0:
                 set_err("DNSSEC VERIFY")
-                detail_log("dnssec-verify:\n" + err.strip())
+                detail_log(" <dnssec-verify>\n" + err.strip())
                 self.backup()
+            else:
+                detail_log(" <dnssec-verify>\n" + err.strip())
 
         if ldns_check:
             cmd = Popen(["ldns-verify-zone", self.path],
@@ -139,8 +141,10 @@ class ZoneFile(object):
 
             if cmd.returncode != 0:
                 set_err("LDNS VERIFY")
-                detail_log("ldns-verify-zone:\n" + err.strip())
+                detail_log(" <ldns-verify-zone>\n" + err.strip())
                 self.backup()
+            else:
+                detail_log(" <ldns-verify-zone>\n" + out.strip())
 
         detail_log(SEP)