Enable tunables by default

All of the major architectures are adopting tunables as a way to add
tuning to the library, from hwcap_mask for aarch64 to HLE for s390 and
ifunc and cache geometry for x86.  Given this adoption and the fact
that we don't want additional tuning knobs to be added outside of
tunables, it makes sense to enable tunables by default using this
trivial patch.

Smoke tested on x86 to ensure that tunables code was built without
specifying it as a configure flag.  I have kept it as --enabled and
not changed it to --disable since we want to still keep the option of
different kinds of front-ends for tunables.

	* configure.ac(--enable-tunables): Enable by default.
	* configure: Regenerate.
	* NEWS: Mention change.
	* manual/install.texi (enable-tunables): Adjust documentation.
	* INSTALL: Regenerate.

diff --git a/ChangeLog b/ChangeLog
index a2d1f5ade160c62a384715dbec42286716977d4c..833f03ea6f5b065d7a811cc65b665b6106796303 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2017-06-15  Siddhesh Poyarekar  <siddhesh@sourceware.org>
+
+       * configure.ac(--enable-tunables): Enable by default.
+       * configure: Regenerate.
+       * NEWS: Mention change.
+       * manual/install.texi (enable-tunables): Adjust documentation.
+       * INSTALL: Regenerate.
+
 2017-06-14  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 
        [BZ #18988]

diff --git a/INSTALL b/INSTALL
index 920c4df0efb9cf7d8651c71d2a49c80e61fc0ba7..a2f5a40b1740d9899502798458ad274bb92e1b57 100644 (file)
--- a/INSTALL
+++ b/INSTALL
@@ -177,18 +177,16 @@ will be used, and CFLAGS sets optimization options for the compiler.
 
 '--enable-tunables'
      Tunables support allows additional library parameters to be
-     customized at runtime.  This is an experimental feature and affects
-     startup time and is thus disabled by default.  This option can take
-     the following values:
-
-     'no'
-          This is the default if the option is not passed to configure.
-          This disables tunables.
+     customized at runtime.  This feature is enabled by default.  This
+     option can take the following values:
 
      'yes'
-          This is the default if the option is passed to configure.
-          This enables tunables and selects the default frontend
-          (currently 'valstring').
+          This is the default if no option is passed to configure.  This
+          enables tunables and selects the default frontend (currently
+          'valstring').
+
+     'no'
+          This option disables tunables.
 
      'valstring'
           This enables tunables and selects the 'valstring' frontend for

diff --git a/NEWS b/NEWS
index 8d35bd6c957d4f11fa1cd1db1068998261ddc14e..804c1b92e6941f6b18dbd8dcf2a3b6d0368f038c 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -95,6 +95,9 @@ Version 2.26
   as atomic variables to try to implement Dekker's mutual exclusion
   algorithm).
 
+* The tunables feature is now enabled by default.  This allows users to tweak
+  behavior of the GNU C Library using the GLIBC_TUNABLES environment variable.
+
 Security related changes:
 
 * The DNS stub resolver limits the advertised UDP buffer size to 1200 bytes,

diff --git a/configure b/configure
index 4c2922d882cd996daa6e522b12ef08c3a3cdc432..8390f2b86e3c8752330a9624613f43ed2675a282 100755 (executable)
--- a/configure
+++ b/configure
@@ -3725,7 +3725,7 @@ fi
 if test "${enable_tunables+set}" = set; then :
   enableval=$enable_tunables; have_tunables=$enableval
 else
-  have_tunables=no
+  have_tunables=yes
 fi
 
 

diff --git a/configure.ac b/configure.ac
index 3f486d6df491c5ec1833ae949e22e6dfbaad4e22..4c0a18edd95e749a9f0138f961605f4a77d0d1a4 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -436,7 +436,7 @@ AC_ARG_ENABLE([tunables],
              [AS_HELP_STRING([--enable-tunables],
               [Enable tunables support. Known values are 'yes', 'no' and 'valstring'])],
              [have_tunables=$enableval],
-             [have_tunables=no])
+             [have_tunables=yes])
 AC_SUBST(have_tunables)
 if test "$have_tunables" = yes; then
   AC_DEFINE(HAVE_TUNABLES)

diff --git a/manual/install.texi b/manual/install.texi
index d39d2daacd0f227e3941e9d973e799e5fd48c219..cbc912817aa61d1c7d395512dfdc573f968fd350 100644 (file)
--- a/manual/install.texi
+++ b/manual/install.texi
@@ -208,18 +208,17 @@ Use this option to disable the vector math library.
 
 @item --enable-tunables
 Tunables support allows additional library parameters to be customized at
-runtime.  This is an experimental feature and affects startup time and is thus
-disabled by default.  This option can take the following values:
+runtime.  This feature is enabled by default.  This option can take the
+following values:
 
 @table @code
-@item no
-This is the default if the option is not passed to configure. This disables
-tunables.
-
 @item yes
-This is the default if the option is passed to configure. This enables tunables
+This is the default if no option is passed to configure. This enables tunables
 and selects the default frontend (currently @samp{valstring}).
 
+@item no
+This option disables tunables.
+
 @item valstring
 This enables tunables and selects the @samp{valstring} frontend for tunables.
 This frontend allows users to specify tunables as a colon-separated list in a