]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
Remove redundant management group cipher suite selector writing
authorRohan Dutta <quic_drohan@quicinc.com>
Fri, 11 Apr 2025 14:59:09 +0000 (20:29 +0530)
committerJouni Malinen <j@w1.fi>
Fri, 9 May 2025 07:24:04 +0000 (10:24 +0300)
Remove the default BIP (AES-128-CMAC) from the code writing the group
management cipher selector into an RSNE since this field is omitted when
the default value is used. This case was unreachable due to the earlier
if statement skipping this switch statement.

Signed-off-by: Rohan Dutta <quic_drohan@quicinc.com>
src/ap/wpa_auth_ie.c

index 2e5f59ec1ad2e279bf4bab488b44080b7a47d583..83ae4e065fa563de3fbb017453dc7c3cd82cf21e 100644 (file)
@@ -346,9 +346,6 @@ static u8 * rsne_write_data(u8 *buf, size_t len, u8 *pos, int group,
 
                /* Management Group Cipher Suite */
                switch (group_mgmt_cipher) {
-               case WPA_CIPHER_AES_128_CMAC:
-                       RSN_SELECTOR_PUT(pos, RSN_CIPHER_SUITE_AES_128_CMAC);
-                       break;
                case WPA_CIPHER_BIP_GMAC_128:
                        RSN_SELECTOR_PUT(pos, RSN_CIPHER_SUITE_BIP_GMAC_128);
                        break;