]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clk: qcom: clk-alpha-pll: Fix the pll post div mask
authorSatya Priya Kakitapalli <quic_skakitap@quicinc.com>
Wed, 31 Jul 2024 06:29:09 +0000 (11:59 +0530)
committerBjorn Andersson <andersson@kernel.org>
Thu, 1 Aug 2024 02:56:09 +0000 (21:56 -0500)
The PLL_POST_DIV_MASK should be 0 to (width - 1) bits. Fix it.

Fixes: 1c3541145cbf ("clk: qcom: support for 2 bit PLL post divider")
Cc: stable@vger.kernel.org
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
Link: https://lore.kernel.org/r/20240731062916.2680823-2-quic_skakitap@quicinc.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/clk-alpha-pll.c

index d873140425287a614def57a5a1119e3f8d841d78..9ce45cd6e09f0cb73814cbb09ef1e1509b68d72f 100644 (file)
@@ -40,7 +40,7 @@
 
 #define PLL_USER_CTL(p)                ((p)->offset + (p)->regs[PLL_OFF_USER_CTL])
 # define PLL_POST_DIV_SHIFT    8
-# define PLL_POST_DIV_MASK(p)  GENMASK((p)->width, 0)
+# define PLL_POST_DIV_MASK(p)  GENMASK((p)->width - 1, 0)
 # define PLL_ALPHA_EN          BIT(24)
 # define PLL_ALPHA_MODE                BIT(25)
 # define PLL_VCO_SHIFT         20