]> git.ipfire.org Git - thirdparty/dnspython.git/commitdiff
Fix: Allow tuple in nameservers type check (#1209)
authorOleksiy ("Alex") SEMENYAKA <219867960+alexsemenyaka@users.noreply.github.com>
Mon, 21 Jul 2025 20:32:54 +0000 (23:32 +0300)
committerGitHub <noreply@github.com>
Mon, 21 Jul 2025 20:32:54 +0000 (13:32 -0700)
* Fix: Allow tuple in nameservers type check

* Update resolver.py

Add missing space.

* Update documentation.

---------

Co-authored-by: Alex Semenyaka <alex.semenyaka@gmail.com>
Co-authored-by: Brian Wellington <bwelling@xbill.org>
dns/resolver.py

index 47e2556b7c439918349d3c79d08aa8c6ebaca484..fef9e84a4acd5f7b117b2ed8d73c80635fc1be97 100644 (file)
@@ -1190,7 +1190,7 @@ class BaseResolver:
         default_port: int,
     ) -> List[dns.nameserver.Nameserver]:
         enriched_nameservers = []
-        if isinstance(nameservers, list):
+        if isinstance(nameservers, (list, tuple)):
             for nameserver in nameservers:
                 enriched_nameserver: dns.nameserver.Nameserver
                 if isinstance(nameserver, dns.nameserver.Nameserver):
@@ -1229,7 +1229,7 @@ class BaseResolver:
         self, nameservers: Sequence[Union[str, dns.nameserver.Nameserver]]
     ) -> None:
         """
-        *nameservers*, a ``list`` of nameservers, where a nameserver is either
+        *nameservers*, a ``list`` or ``tuple`` of nameservers, where a nameserver is either
         a string interpretable as a nameserver, or a ``dns.nameserver.Nameserver``
         instance.