The dcbt and dcbtst instructions provide a non-zero hint that describes

a block or data stream to which a program may perform a Store acces,
or indicates the expected use.  The field bits[25:21] (bits 6:10 in
the IBM numbering) in the instruction provide the hint.

Valgrind checks that these bits are non-zero.  Unfortunately, the test was
being applied to other instructions such as the dcbf instruction causing
it to fail when the field was equal to zero.  This patch removes the check
that was being incorrectly applied to all of the instructions.

The valgrind bugzilla for this issue is 348334.

git-svn-id: svn://svn.valgrind.org/vex/trunk@3148

diff --git a/VEX/priv/guest_ppc_toIR.c b/VEX/priv/guest_ppc_toIR.c
index f15e1664152cd4add1cd344a6cdf9b72ed43927d..103ed368c8bada4bc29ef2e30f21b1f6feec1ca7 100644 (file)
--- a/VEX/priv/guest_ppc_toIR.c
+++ b/VEX/priv/guest_ppc_toIR.c
@@ -7462,10 +7462,10 @@ static Bool dis_cache_manage ( UInt         theInstr,
       }
    }
 
-   if (opc1 != 0x1F || b21to25 != 0 || b0 != 0) {
+   if (opc1 != 0x1F || b0 != 0) {
       if (0) vex_printf("dis_cache_manage %d %d %d\n", 
-                        (Int)opc1, (Int)b21to25, (Int)b0);
-      vex_printf("dis_cache_manage(ppc)(opc1|b21to25|b0)\n");
+                        (Int)opc1, (Int)b0);
+      vex_printf("dis_cache_manage(ppc)(opc1|b0)\n");
       return False;
    }