]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
lib: Use talloc_asprintf_addbuf() in str_list_join()
authorVolker Lendecke <vl@samba.org>
Mon, 28 Nov 2022 09:43:06 +0000 (10:43 +0100)
committerJeremy Allison <jra@samba.org>
Wed, 14 Dec 2022 04:32:34 +0000 (04:32 +0000)
This adds intermediate NULL checks via talloc_asprintf_addbuf()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
lib/util/util_strlist.c

index 08a23dd60f2d35cfeebf5b9e1f3d1dac5523e2d5..a1b80d464d5668a2b6f929951566f0bb9971878d 100644 (file)
@@ -188,7 +188,7 @@ _PUBLIC_ char *str_list_join(TALLOC_CTX *mem_ctx, const char **list, char separa
        ret = talloc_strdup(mem_ctx, list[0]);
 
        for (i = 1; list[i]; i++) {
-               ret = talloc_asprintf_append_buffer(ret, "%c%s", separator, list[i]);
+               talloc_asprintf_addbuf(&ret, "%c%s", separator, list[i]);
        }
 
        return ret;