[#1219] Addressed comments

diff --git a/src/hooks/dhcp/high_availability/ha_service.cc b/src/hooks/dhcp/high_availability/ha_service.cc
index 72c669fc813605f498cfa98d8d7ea709a16cd5e5..52f1cf1874f973c524747b41bb6f63cf99229ee0 100644 (file)
--- a/src/hooks/dhcp/high_availability/ha_service.cc
+++ b/src/hooks/dhcp/high_availability/ha_service.cc
@@ -963,7 +963,6 @@ void
 HAService::updatePendingRequestInternal(QueryPtrType& query) {
     if (pending_requests_.count(query) == 0) {
         pending_requests_[query] = 1;
-
     } else {
         ++pending_requests_[query];
     }

diff --git a/src/hooks/dhcp/high_availability/ha_service.h b/src/hooks/dhcp/high_availability/ha_service.h
index 448b11962e6eafdd3fe1bb3a791d46a64b588201..7061476f03371986cf56adb653bc665e7f61f6b5 100644 (file)
--- a/src/hooks/dhcp/high_availability/ha_service.h
+++ b/src/hooks/dhcp/high_availability/ha_service.h
@@ -933,7 +933,7 @@ protected:
     /// @param [out] parking_lot Parking lot where the query is parked.
     /// This method uses this handle to unpark the packet when all asynchronous
     /// requests have been completed.
-    /// @return True when all lease updates are complete, false otherwise.
+    /// @return When all lease updates are complete returns true, false otherwise.
     template<typename QueryPtrType>
     bool leaseUpdateComplete(QueryPtrType& query,
                              const hooks::ParkingLotHandlePtr& parking_lot);
@@ -962,19 +962,23 @@ private:
     ///  - if there was one remove the query from the map
     ///  - return true
     ///
+    /// Should be called in a thread safe context.
+    ///
     /// @tparam QueryPtrType Type of the pointer to the DHCP client's message,
     /// i.e. Pkt4Ptr or Pkt6Ptr.
     /// @param query Pointer to the DHCP client's query.
     /// @param [out] parking_lot Parking lot where the query is parked.
     /// This method uses this handle to unpark the packet when all asynchronous
     /// requests have been completed.
-    /// @return True when all lease updates are complete, false otherwise.
+    /// @return When all lease updates are complete returns true, false otherwise.
     template<typename QueryPtrType>
     bool leaseUpdateCompleteInternal(QueryPtrType& query,
                                      const hooks::ParkingLotHandlePtr& parking_lot);
 
     /// @brief Update pending request counter for this query.
     ///
+    /// Should be called in a thread safe context.
+    ///
     /// @tparam QueryPtrType Type of the pointer to the DHCP client's message,
     /// i.e. Pkt4Ptr or Pkt6Ptr.
     /// @param query Pointer to the DHCP client's query.