]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
regmap: Fix regmap_bulk_read in BE mode
authorArun Chandran <achandran@mvista.com>
Mon, 15 Jun 2015 10:29:02 +0000 (15:59 +0530)
committerZefan Li <lizefan@huawei.com>
Thu, 22 Oct 2015 01:20:04 +0000 (09:20 +0800)
commit 15b8d2c41fe5839582029f65c5f7004db451cc2b upstream.

In big endian mode regmap_bulk_read gives incorrect data
for byte reads.

This is because memcpy of a single byte from an address
after full word read gives different results when
endianness differs. ie. we get little-end in LE and big-end in BE.

Signed-off-by: Arun Chandran <achandran@mvista.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
[lizf: Backported to 3.4: format_val() takes only two arguments]
Signed-off-by: Zefan Li <lizefan@huawei.com>
drivers/base/regmap/regmap.c

index 8e81f85b1ba008d5d45399e45d37bdf08a0d2616..0ac67aca79055a98eeff3385fb3bedd6ac689115 100644 (file)
@@ -784,7 +784,7 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val,
                        ret = regmap_read(map, reg + i, &ival);
                        if (ret != 0)
                                return ret;
-                       memcpy(val + (i * val_bytes), &ival, val_bytes);
+                       map->format.format_val(val + (i * val_bytes), ival);
                }
        }