]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
afs: Fix missing wire-up of afs_retry_request()
authorDavid Howells <dhowells@redhat.com>
Sat, 14 Sep 2024 20:40:02 +0000 (21:40 +0100)
committerChristian Brauner <brauner@kernel.org>
Fri, 27 Sep 2024 16:29:19 +0000 (18:29 +0200)
afs_retry_request() is supposed to be pointed to by the afs_req_ops netfs
operations table, but the pointer got lost somewhere.  The function is used
during writeback to rotate through the authentication keys that were in
force when the file was modified locally.

Fix this by adding the pointer to the function.

Fixes: 1ecb146f7cd8 ("netfs, afs: Use writeback retry to deal with alternate keys")
Reported-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/1690847.1726346402@warthog.procyon.org.uk
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: linux-afs@lists.infradead.org
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/afs/file.c

index 492d857a3fa0728fa1fd8628c96465939b42d3ff..6762eff9751722c3950f1a90df1de515887b0fb4 100644 (file)
@@ -420,6 +420,7 @@ const struct netfs_request_ops afs_req_ops = {
        .begin_writeback        = afs_begin_writeback,
        .prepare_write          = afs_prepare_write,
        .issue_write            = afs_issue_write,
+       .retry_request          = afs_retry_request,
 };
 
 static void afs_add_open_mmap(struct afs_vnode *vnode)