]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
reset: starfive: jh71x0: Fix accessing the empty member on JH7110 SoC
authorChanghuang Liang <changhuang.liang@starfivetech.com>
Wed, 25 Sep 2024 11:24:42 +0000 (04:24 -0700)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Mon, 30 Sep 2024 12:24:37 +0000 (14:24 +0200)
data->asserted will be NULL on JH7110 SoC since commit 82327b127d41
("reset: starfive: Add StarFive JH7110 reset driver") was added. Add
the judgment condition to avoid errors when calling reset_control_status
on JH7110 SoC.

Fixes: 82327b127d41 ("reset: starfive: Add StarFive JH7110 reset driver")
Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Acked-by: Hal Feng <hal.feng@starfivetech.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20240925112442.1732416-1-changhuang.liang@starfivetech.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/reset/starfive/reset-starfive-jh71x0.c

index 55bbbd2de52cf9388ff256e5248c3513dfe32ccf..29ce3486752f38feb64817a7de2f4ff18fbee7d8 100644 (file)
@@ -94,6 +94,9 @@ static int jh71x0_reset_status(struct reset_controller_dev *rcdev,
        void __iomem *reg_status = data->status + offset * sizeof(u32);
        u32 value = readl(reg_status);
 
+       if (!data->asserted)
+               return !(value & mask);
+
        return !((value ^ data->asserted[offset]) & mask);
 }