Check data directory's permission while updating sources

Closes redmine ticket #3219.

diff --git a/suricata/update/commands/updatesources.py b/suricata/update/commands/updatesources.py
index a47c24c569ce1495f4c71211b9d98ca1578692c6..06a0d1172748179042add22ee0d03585253957af 100644 (file)
--- a/suricata/update/commands/updatesources.py
+++ b/suricata/update/commands/updatesources.py
@@ -71,8 +71,12 @@ def compare_sources(initial_content, final_content):
 
 
 def write_and_compare(initial_content, fileobj):
-    with open(local_index_filename, "wb") as outobj:
-        outobj.write(fileobj.getvalue())
+    try:
+        with open(local_index_filename, "wb") as outobj:
+            outobj.write(fileobj.getvalue())
+    except IOError as ioe:
+        logger.error("Failed to open directory: %s", ioe)
+        return 1
     with open(local_index_filename, "rb") as stream:
         final_content = yaml.safe_load(stream)
     compare_sources(initial_content, final_content)