]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
ipila: Fixed unitialized variables
authorTom Herbert <tom@herbertland.com>
Mon, 15 Aug 2016 23:30:22 +0000 (16:30 -0700)
committerStephen Hemminger <sthemmin@microsoft.com>
Wed, 17 Aug 2016 20:51:18 +0000 (13:51 -0700)
Initialize locator and locator_match to zero and only do
addattr if they have been set.

Signed-off-by: Tom Herbert <tom@herbertland.com>
ip/ipila.c

index c30bdbf166a627982ae6dd719dc8daf64370751e..57f8c79ba2f4006daafe8d16b2a9d37408a189f1 100644 (file)
@@ -149,8 +149,8 @@ static int do_list(int argc, char **argv)
 static int ila_parse_opt(int argc, char **argv, struct nlmsghdr *n,
                         bool adding)
 {
-       __u64 locator;
-       __u64 locator_match;
+       __u64 locator = 0;
+       __u64 locator_match = 0;
        int ifindex = 0;
        bool loc_set = false;
        bool loc_match_set = false;
@@ -202,8 +202,11 @@ static int ila_parse_opt(int argc, char **argv, struct nlmsghdr *n,
                }
        }
 
-       addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match);
-       addattr64(n, 1024, ILA_ATTR_LOCATOR, locator);
+       if (loc_match_set)
+               addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match);
+
+       if (loc_set)
+               addattr64(n, 1024, ILA_ATTR_LOCATOR, locator);
 
        if (ifindex_set)
                addattr32(n, 1024, ILA_ATTR_IFINDEX, ifindex);