]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
octeontx2-af: Fix PF driver crash with kexec kernel booting
authorAnshumali Gaur <agaur@marvell.com>
Tue, 3 Feb 2026 05:07:01 +0000 (10:37 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Feb 2026 20:34:25 +0000 (12:34 -0800)
During a kexec reboot the hardware is not power-cycled, so AF state from
the old kernel can persist into the new kernel. When AF and PF drivers
are built as modules, the PF driver may probe before AF reinitializes
the hardware.

The PF driver treats the RVUM block revision as an indication that AF
initialization is complete. If this value is left uncleared at shutdown,
PF may incorrectly assume AF is ready and access stale hardware state,
leading to a crash.

Clear the RVUM block revision during AF shutdown to avoid PF
mis-detecting AF readiness after kexec.

Fixes: 54494aa5d1e6 ("octeontx2-af: Add Marvell OcteonTX2 RVU AF driver")
Signed-off-by: Anshumali Gaur <agaur@marvell.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20260203050701.2616685-1-agaur@marvell.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/af/rvu.c

index 747fbdf2a908f12805bc90e2daf2fdfd5a7d7cc4..8530df8b3fdaf763d74e913cab6698a908a131f4 100644 (file)
@@ -3632,11 +3632,22 @@ static void rvu_remove(struct pci_dev *pdev)
        devm_kfree(&pdev->dev, rvu);
 }
 
+static void rvu_shutdown(struct pci_dev *pdev)
+{
+       struct rvu *rvu = pci_get_drvdata(pdev);
+
+       if (!rvu)
+               return;
+
+       rvu_clear_rvum_blk_revid(rvu);
+}
+
 static struct pci_driver rvu_driver = {
        .name = DRV_NAME,
        .id_table = rvu_id_table,
        .probe = rvu_probe,
        .remove = rvu_remove,
+       .shutdown = rvu_shutdown,
 };
 
 static int __init rvu_init_module(void)